great progress on dive site handling

[Dirk Hohndel]

On Sun, Jun 28, 2015 at 06:35:25AM +0800, Miika Turkia wrote:
> 
> I had the site on my log with only a name, no coordinates. Now I dove
> there again with companion app. Synced the GPS data and then selected
> the name of the dive site. This replaced all info from the old dive
> site, overwriting the gps with empty value.
> 
> I would prefer a merge where we take the values over empty fields, no
> matter which one is newer.

I hacked the logic to make this work. I think this is totally bogus and
bad UI design and actually the wrong thing to do, but let's not get
distracted by little details like this.

With the commit I just pushed the following happens.

IFF you have a dive site that was downloaded from the companion app and
IFF you either type in a new name or you type in an existing dive site
name that has no GPS data,
THEN the GPS data from the downloaded fix will be used and added to the
new dive site that is created (or the existing dive site that didn't have
a GPS fix).

This behavior is of course ridiculously stupid and inconsistent with the
behavior this field usually has. But it solves the problem for people who
for some weird reason download their GPS information before assigning
names to their dive sites.

Please test and let me know if this works for you.

> >> - It would be great if the currently selected divesite was highlighted
> >> somehow on the map, it is really hard to spot it now when the sites
> >> are close to each other, maybe the dive map changed or something to
> >> ensure the correct spot is recognized.
> > 
> > That has been unchanged for a long time. I'll think about something.
> 
> Yes, I have suffered from it for years :) Anyway, it is more prominenet
> when using the companion app and trying to see where the last dive was..

Changes that implement that have been pushed as well. The current dive now
has a 25% bigger and quite significantly brighter flag.

/D