[PATCH 1/4] Add support for importing o2 sensors from CSV file

Anton Lundin glance at acc.umu.se
Sun Jun 28 01:51:54 PDT 2015


On 27 June, 2015 - Dirk Hohndel wrote:

> On Sat, Jun 27, 2015 at 11:38:10PM +0200, Anton Lundin wrote:
> > 
> > Dam, this code is clunky. We should really rework how that field-thingie
> > works.
> > 
> > I want to pry my eyes out every time i touch that code.
> > 
> > How many places do you need to touch to add a field to the csv-importer?
> >  - To many!
> 
> It's pretty disgusting, that's for sure.
> I'm open to ideas for a redesign. But I always wonder about the
> cost/benefit analysis of things like that...

Yea. I did some half-ass try to rework it but it turned out to look even
worse.

I'm kinda out of ideas on how to do something less ugly here.


//Anton


-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list