Three patches
Thiago Macieira
thiago at macieira.org
Mon Mar 2 10:18:30 PST 2015
On Monday 02 March 2015 16:31:33 Robert Helling wrote:
> + QUrl url(picture->filename);
Please don't do this.
Either the string contains a URL or it contains a file name. Do not mix the
two.
If the string contains a URL, please rename the variable and make sure it
doesn't get passed directly to the likes of QFile.
If the string contains a file name, please use QUrl::fromLocalFile.
If the string is something the user typed and you don't know the content, use
QUrl::fromUserInput right as you got the string, and then treat it as a URL.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
More information about the subsurface
mailing list