[PATCH 2/2] Ticket #831 Fix

[Robert Helling]

Hi,

> On 09.03.2015, at 06:49, Yosef Hamza <jo.adam.93 at gmail.com> wrote:
> 
> But I think that the second patch needs some discussion.


I don’t think just displaying the initial gas changes is a solution as as you can read in the comments, some dive computers use such events to indicate the gas used and this would confuse the users if the event were displayed.

Also I don’t think there can be genuine gas _changes_ at t=0 so I doubt we need to separate those from the implicit ones (for example by making sure event times are really signed and reserving negative times for such invisible events).

I think a better solution would be to make sure that if the user adds a gas change at t=0 (or negative times given the other patch) it overwrites the other gas change, i.e. when adding a gas change first delete all other gas changes at the same time.

Best
Robert

--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150309/004ec44c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150309/004ec44c/attachment.sig>