[PATCH 1/2] Ticket #837 Fix

[Yosef Hamza]

If the user hasn't made any changes and now it displays "Add location"
"close".

Is there anything special that should happen when the choose "Add location"?

If now why it has to change when the user make changes, we can keep "Add
location"
instead of "Save and close"?

Let me know what you think.

§Yousef


On Mon, Mar 9, 2015 at 5:57 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

> On Mon, Mar 09, 2015 at 07:45:31AM +0200, Yosef Hamza wrote:
> > The fix is according to the comment on the ticket.
>
> - your patch was attached as base64 encoded attachment. Nothing horribly
>   wrong with that, but it's inconvenient as it makes it hard to comment on
>   the code in a response.
> - changing the names (and the order) of the buttons isn't exactly a fix
>   for the issue -- what needs to happen is that the message bar is shown
>   with actions that make sense:
>   -- Add location / close (if the user hasn't made any changes)
>   -- Save and close / Discard and close (if the user has made changes or
>      selected to add a site)
>
> For an "easy fix" ticket I'd be happy with a solution that ignores the
> "add" part of this. So make the message bar show "Close" by default and
> Save / Discard once the user starts editing.
>
> /D
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150309/c1179b6e/attachment.html>