[PATCH 1/2] Ticket #837 Fix

Yosef Hamza jo.adam.93 at gmail.com
Mon Mar 9 16:08:19 PDT 2015


On Mon, Mar 9, 2015 at 9:05 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

> Yosef,
>
> please try to figure out how to answer inline. This is a technical mailing
> list where top posting is considered quite annoying. The occasional email
> from a phone may be acceptable, but in general we expect people to use in
> line responses...
>
Sorry about that...

>
> On Mon, Mar 09, 2015 at 07:01:09PM +0200, Yosef Hamza wrote:
> > If the user hasn't made any changes and now it displays "Add location"
> > "close".
> >
> > Is there anything special that should happen when the choose "Add
> location"?
>
> As I said, that exceeds the "easy fix" part of this. Yes, we should add
> the code that allows people to create a new location. But that's a bit
> more complicated. For the first patch I'll be happy with something that
> just has a close button there by default.


I don't quite get it, Should I create a new location with some default
values
since the form is empty (user hasn't made any changes to it)?

>
>
> If now why it has to change when the user make changes, we can keep "Add
> > location"
> > instead of "Save and close"?
>
> I can't parse that sentence. Can you try again
>
> I meant we can just keep the action text to "Add location" instead of
changing it to
"Save and close" and only change "Close" to "Discard and close" when the
user
make some changes.

§Yousef
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150310/b2aff4ed/attachment.html>


More information about the subsurface mailing list