[PATCH 2/2] Ticket #831 Fix

[Joakim Bygdell]

On 10 March 2015 at 12:08, Davide DB <dbdavide at gmail.com> wrote:

> If I recall it correctly, I remember that some developer told me that
> having at least a cylinder is compulsory.
> Why?
>
When I import dives from my Viper in gauge mode, the cylinder table is
> originally empty.
> When I import from my Xdeep I have a unkonwn cylinder (it's logged
> into the imported uddf file).
>

Probably due to the reason that the UDDF format have a cylinder tag as
default, but with no size and pressure information in it subsurface then
treats it as unknown.


> I'll try to explain...
> If I do not care about tanks and gases I will not touch cylinder table
>
> If I care about gases and tanks I will edit its content: Once I have
> all my tanks into the table I should be able to freely arrange them
> without making any assumption on main/default cylinders.
>
> Right now the app tries to guide you deciding what is the starting
> tank so you cannot add a gas change to it.
>

You can change back to the first gas later in the dive if you have done a
switch to another gas.
If you have say 4 different gas mixes during a dive you can have a gas
change series that does not follow the order of the gases in the table,
with the exception that you always start with the first gas.
So a switch series that look like this is fully valid. (1), 3, 1, 2, 4


> I should just be able to pinpoint, to choose the tank I entered the
> water (or you can call it default/main tank) in to the table. By
> default the cylinder table will have a main/default cylinder: if user
> doesn't have strange needs he will not touch it. This is better than
> having a forced gas change at 0 at 0.
> Then tanks are sorted via the gas change events: as I add/delete them
> on the profile graph, tanks are automatically sorted in the table. If
> a tank is used more than once, only the first gas change move it in
> the table.
>

In order to be able to switch to a gas it first needs to exist in the
cylinder table.


> There is still a problem with the current index management: when I
> copy a tank set from a dive, their index are copied as well. They
> should not (must be an oprional parameter). They will added again when
> I will add gas changes.
>
>
> I'm sure i forgot something or I made some mistake because I don't
> know the inner algorithm used by the app to manage all that burden :)
>
>
//
Jocke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150310/f5543b73/attachment.html>