dive profile points

Lubomir I. Ivanov neolit123 at gmail.com
Wed Mar 11 15:25:43 PDT 2015


hey Miika,

this prevents deletion of divepoints on a newly added dive completely
(Log -> Add dive):
http://trac.subsurface-divelog.org/changeset/4f9705f3f54fc14d6b38123160f07015c41f3519/subsurface

new bug report:
http://trac.subsurface-divelog.org/ticket/846

i can't really reproduce what the comment describes:
* If we end up having divepoints that are not within the dive
* profile, we need to just skip the removal to prevent
* crashing due to index out of range.

i always get this for any dive:
rowCount() == divepoints.count()
can you provide steps?

but also, shouldn't the check be like so?:
if (rowCount() > divepoints.count())

i wonder how is it even possible for divepoints to not be a part of
the dive profile.
if there another underlying bug here perhaps we should remove the
check and fix that instead...

lubomir
--


More information about the subsurface mailing list