dive profile points

[Lubomir I. Ivanov]

On 12 March 2015 at 09:18, Willem Ferguson
<willemferguson at zoology.up.ac.za> wrote:
>
> Here is a procedure for replicating this reliably on my linux box.
> 1) Add->dive This gives last part of default profile as in attached image:
> initial.png.
> 2) Slowly drag the last point og the bottom section of the profile to the
> right, past the end of the profile. Point separates from profile. See
> attached image: outsidepoint.png. Now there are 3 points towards the right
> end of the bottom section of the profile
> 3) Delete the leftmost of the above three points. It disappears. See image:
> delete_1.png.
> 4) Now delete the middle of the original 3 points. It disappears, but point
> #1 that has been deleted re-appears. See delete_2.png
> One can go on ad infinitum trying to delete these points.
>
> Another issue that may be important: In the dive profile at the top lefthand
> corner is what appears to be a point. See origin.png. I cannot drag it. What
> gives?
>
> I am so glad this issue is addressed now because this is exactly the sort of
> stuff that strongly discourages a first-time user of Subsurface.

hello Willem,

i've just sent some patches to the ML, can you and Miika give them a test.

[PATCH 3/4] Profile: call clearHandlers() in setAddState()
is one of interest; i think it solves this particular issue you describe.

but i'm pretty sure there are some more bugs related to duplicate
points, lurking here:
- add new dive
- add cylinder with gas mix (e.g. 15% He)
- set one of the points in the profile to have a gas change
- cylinder <-> icons appear
- apply
- cylinder <-> icons are gone (?)
- enter "edit mode" for said dive
(note: we need to enable double-click or something on the profile to
enter "edit mode")
- duplicate points appear at the gas change and at the 0sec / 0m coordinate
- all gas text turn back to AIR

seems like there is a one or more bugs here; can someone confirm?

lubomir
--