[PATCH] Improved adding images

Dirk Hohndel dirk at hohndel.org
Sun Mar 15 16:10:56 PDT 2015


On Sun, Mar 15, 2015 at 10:33:53PM +0100, Jan Darowski wrote:
> I've cleaned whitespaces, removed completely qstrdump (left one
> copy_string where it was needed), merged 2 later patches into one (3.
> was just changing message from 2.), changed author of the commits to
> match Signed-off-by.

Nicely done.

I'll take the patches as they are but would like you to work a bit more on
this topic:

a) when the user makes changes to the direction of shift, the information
displayed should be updated
b) don't show the full path, just show the file names
c) also show the start and end time of the dive

Finally, I just tried this with a few pictures and couldn't get things to
work. Now I haven't used this feature in ages and maybe I'm confused, but
I have four pictures from a dive and the time offset for them is 7h and
I'm certain that at one point in the past they were displayed correctly,
but things don't work when I try it now... this could be user error, but
I'd love it if some others would play with this as well to make sure
nothing got broken.

For me, even if the times were shifted correctly it still showed the
warning and if I ignored the warning no pictures were shown on the
profile... I haven't debugged the issue any further as I figured that you
had looked at this code just recently and maybe would be willing to
continue working on it.

/D


More information about the subsurface mailing list