Fwd: Three patches

Robert Helling helling at lmu.de
Mon Mar 16 12:23:35 PDT 2015


Dirk,

it seems, these never got applied.

(one more coming).

Best
Robert

Begin forwarded message:

> From: Robert Helling <helling at lmu.de>
> Subject: Three patches
> Date: 2 Mar 2015 16:31:33 GMT+1
> To: Subsurface Mailing List <subsurface at subsurface-divelog.org>
> 
> Hi,
> 
> here are three more patches.
> 
> 
> 
> 
> 
> 0001 fixes a crash when the dive does not yet have a divesite and one loads images with geolocation data. I am not 100% sure this dive-site is properly added, but at least it fixes the crash.
> 
> 0002 corrects a wrong signature of a helper function (call by value)
> 
> 0003 adds the possibility to have URLs in image filenames. If loading an image by filename and by hash fails, we try to interpret the filename as URL and download the image file to a local cache directory (N.B. also QStandardPaths::standardLocations(QStandardPaths::CacheLocation) seems to give a non-existant directory on my mac that needs to be created for this to work) and then hashes treats the file as local with a hash. So far, the only possibility to have such URL filenames is by editing the xml. dives/test39.xml is added which contains such a filename.
> 
> Best
> Robert
> 
> -- 
> .oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
> Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
>                       Scientific Coordinator
>                       Ludwig Maximilians Universitaet Muenchen, Dept. Physik
>                       Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
>                       http://www.atdotde.de
> 
> Enhance your privacy, use cryptography! My PGP keys have fingerprints
> A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
> DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F
> 
> 
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150316/fa2d1f08/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-When-loading-an-image-with-geodata-create-a-divesite-w.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150316/fa2d1f08/attachment.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150316/fa2d1f08/attachment-0001.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Correct-signature-of-helper-function.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150316/fa2d1f08/attachment-0001.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150316/fa2d1f08/attachment-0002.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-Load-remote-images.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150316/fa2d1f08/attachment-0002.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150316/fa2d1f08/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150316/fa2d1f08/attachment.sig>


More information about the subsurface mailing list