Patch for #848

Matthew Vepritskiy matteofichtner at hotmail.com
Tue Mar 17 04:33:43 PDT 2015


Sorry. Lost in Translation.
I caught this bug as follows (pic 1):1. Add new dive.2. Discard apply changes.3. Add another dive.4. Pull the last point to the left or down.5. Make it a few more times.
> also, not sure i understand what you mean by "second diving graph".Was trying to say that the problem occurs on the second editing.
Can I ask you one more time? (pic 2)> Given this, should we clean handles every time changes are discarded or
> applied?
Regards, Matthew V.

> Date: Tue, 17 Mar 2015 12:30:48 +0200
> Subject: Re: Patch for #848
> From: neolit123 at gmail.com
> To: matteofichtner at hotmail.com
> CC: subsurface at subsurface-divelog.org
> 
> On 17 March 2015 at 01:06, Matthew Vepritskiy
> <matteofichtner at hotmail.com> wrote:
> > I made a patch for ticket # 848, but I have a suspicion that somewhere I
> > screwed up.
> > http://trac.subsurface-divelog.org/ticket/848#no2
> >
> > Patch fixes the problem when you can create a set of points that do not
> > belong to the line.
> > The problem lies in the function fixHandlerIndex (qt-ui / profile /
> > profilewidget2.cpp) - it returns the wrong value.
> > However, this only occurs when the user edits the second diving graph. That
> > is, before he clicked "Apply Changes" or "Discard changes".
> > Given this, should we clean handles every time changes are discarded or
> > applied?
> >
> 
> i don't think the function should be removed.
> this bug was supposedly fixed recently and i can't reproduce it with
> the current GIT version. if not, can you provide the exact steps for
> the bug to trigger?
> also, not sure i understand what you mean by "second diving graph".
> 
> lubomir
> --
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150317/9abf8194/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Untitled-1.png
Type: image/png
Size: 129991 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150317/9abf8194/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: untitled-2.png
Type: image/png
Size: 221953 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150317/9abf8194/attachment-0003.png>


More information about the subsurface mailing list