[PATCH] NULL pointer dereference - segfault

Lubomir I. Ivanov neolit123 at gmail.com
Tue Mar 17 17:24:53 PDT 2015


On 18 March 2015 at 02:22, Marcos Cardinot <mcardinot at gmail.com> wrote:
> 2015-03-17 21:16 GMT-03:00 Lubomir I. Ivanov <neolit123 at gmail.com>:
>
>> On 18 March 2015 at 01:45, Marcos Cardinot <mcardinot at gmail.com> wrote:
>> >
>> > Hello folks,
>> >
>> > The current code in RulerItem2::settingsChanged() is dereferencing the
>> > null pointer 'profWidget'.
>> > It can cause a segmentation fault.
>> >
>> >
>>
>> hi, there is no need for the braces { } around the single lined "if"
>> condition.
>> could you remove them and resend?
>
>
> Hi, of course.
> Is there a kind of code style doc somewhere?
>

the source code is the coding style, mostly.
but, yes there is a CodingStyle file in the root folder...also the
"Linux kernel coding style" is a sane reference!

in fact, i just sent a small related change to CodingStyle.

lubomir
--


More information about the subsurface mailing list