[PATCH] NULL pointer dereference - segfault

[Marcos Cardinot]

sorry, I'have sent a wrong fix

I'll have a look at the codestyle file - thanks =D

2015-03-17 21:24 GMT-03:00 Lubomir I. Ivanov <neolit123 at gmail.com>:

> On 18 March 2015 at 02:22, Marcos Cardinot <mcardinot at gmail.com> wrote:
> > 2015-03-17 21:16 GMT-03:00 Lubomir I. Ivanov <neolit123 at gmail.com>:
> >
> >> On 18 March 2015 at 01:45, Marcos Cardinot <mcardinot at gmail.com> wrote:
> >> >
> >> > Hello folks,
> >> >
> >> > The current code in RulerItem2::settingsChanged() is dereferencing the
> >> > null pointer 'profWidget'.
> >> > It can cause a segmentation fault.
> >> >
> >> >
> >>
> >> hi, there is no need for the braces { } around the single lined "if"
> >> condition.
> >> could you remove them and resend?
> >
> >
> > Hi, of course.
> > Is there a kind of code style doc somewhere?
> >
>
> the source code is the coding style, mostly.
> but, yes there is a CodingStyle file in the root folder...also the
> "Linux kernel coding style" is a sane reference!
>
> in fact, i just sent a small related change to CodingStyle.
>
> lubomir
> --
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150317/2dbeb960/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-RulerItem2-settingsChanged-NULL-pointer-dereference.patch
Type: text/x-patch
Size: 1136 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150317/2dbeb960/attachment-0001.bin>