[PATCH] Improved adding images

[Jan Darowski]

Dirk: Do you still have any problems with adding images? If so, could
you send me any examples?

To be honest I'm still not sure how it should look like... Also there
is no easy way of getting number of dives for which I have any photos
selected. The checks logic is closed in the dive.c as Tomaz asked me
at the beginning.

Are you fine with the table solution? (sorry that I didn't respond for
a while, busy time lately).

2015-03-16 8:55 GMT+01:00 Miika Turkia <miika.turkia at gmail.com>:
> On Mon, Mar 16, 2015 at 9:39 AM, Jan Darowski <jan.darowski at gmail.com>
> wrote:
>>
>> Ok, I can introduce changes you mentioned but i'm not sure how to
>> handle multiple dives. Maybe I will introduce some kind of tables, one
>> with filenames and timestamps and the second one with dives and their
>> time range. Then highlight invalid photos... Or just assume that in
>> most cases we only use one dive.
>
>
> I have always had multiple dives selected when importing. Maybe just show
> how many dives had matching images (and possibly the count how many were
> selected). From my point of view, you don't have to show everything, just
> examples of these (having the full count also displayed should make this
> obvious?)
>
> miika
>
>> I did some testing already and for me shifting invalid image works...
>> I'm using exiftool for testing images, if anyone else wants to play a
>> little bit with it.
>>
>>
>> 2015-03-16 6:55 GMT+01:00 Miika Turkia <miika.turkia at gmail.com>:
>> > On Mon, Mar 16, 2015 at 1:10 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>> >>
>> >> On Sun, Mar 15, 2015 at 10:33:53PM +0100, Jan Darowski wrote:
>> >> > I've cleaned whitespaces, removed completely qstrdump (left one
>> >> > copy_string where it was needed), merged 2 later patches into one (3.
>> >> > was just changing message from 2.), changed author of the commits to
>> >> > match Signed-off-by.
>> >>
>> >> Nicely done.
>> >>
>> >> I'll take the patches as they are but would like you to work a bit more
>> >> on
>> >> this topic:
>> >>
>> >> a) when the user makes changes to the direction of shift, the
>> >> information
>> >> displayed should be updated
>> >> b) don't show the full path, just show the file names
>> >> c) also show the start and end time of the dive
>> >
>> >
>> > Some feedback would be nice to have even if everything is aligning
>> > correctly. E.g. dive times of the first time and the time stamp of one
>> > image
>> > that was shot during the dive. Also a count of how many of the loaded
>> > images
>> > are shot within accepted time frame versus all loaded images would be
>> > nice
>> > to have.
>> >
>> >>
>> >> Finally, I just tried this with a few pictures and couldn't get things
>> >> to
>> >> work. Now I haven't used this feature in ages and maybe I'm confused,
>> >> but
>> >> I have four pictures from a dive and the time offset for them is 7h and
>> >> I'm certain that at one point in the past they were displayed
>> >> correctly,
>> >> but things don't work when I try it now... this could be user error,
>> >> but
>> >> I'd love it if some others would play with this as well to make sure
>> >> nothing got broken.
>> >
>> >
>> > I was able to load images properly. However, my clocks were synced at
>> > the
>> > time, so it was easy to import. I did try some time adjustments as well
>> > and
>> > the pics were moved later on the dive, and if long enough shift, then
>> > the
>> > warning message appeared.
>> >
>> >>
>> >> For me, even if the times were shifted correctly it still showed the
>> >> warning and if I ignored the warning no pictures were shown on the
>> >> profile... I haven't debugged the issue any further as I figured that
>> >> you
>> >> had looked at this code just recently and maybe would be willing to
>> >> continue working on it.
>> >
>> >
>> > The warning appeared and disappeared for me when I shifted the pics, but
>> > the
>> > case is different as the times were correct to begin with.
>> >
>> > miika
>> >
>
>