[PATCH] Better solves Bug#860

Lubomir I. Ivanov neolit123 at gmail.com
Sat Mar 21 07:05:44 PDT 2015


On 20 March 2015 at 22:40, Abhinav Agarwal <aagarwal.gtr at gmail.com> wrote:
> While exporting a divelog to xml/ssrf, if given filename contains a dot it doesnt get saved as intended. for eg: if given filename is 'divelog.first' it should get saved as 'divelog.first.ssrf' but it gets saved as 'divelog.first'. This happens only on linux and not on windows. If you were to do the same on windows it would get saved as 'divelog.first.xml'. This patch solves the issue. It is syntactically better than the previous patch I submitted.
>

hello,

for the message body, your patch still has:
Content-Transfer-Encoding: base64

it makes the actual contents unreadable until it's applied (i.e. "git
am" decodes it). you should look into a way to fix that e.g. use "git
format-patch" and "git send-email" with their proper options.

other than that the change seems OK.

lubomir
--


More information about the subsurface mailing list