[PATCH] Fix for ticket #844

[Claudiu Olteanu]

Thanks for your remarks.

You are right, there is no reason to change the parent from "this" to
NULL. I made the changes and attached a new version of the patch.

Claudiu

On Sat, Mar 21, 2015 at 3:55 PM, Lubomir I. Ivanov <neolit123 at gmail.com>
wrote:

> On 20 March 2015 at 23:06, Claudiu Olteanu
> <olteanu.vasilica.claudiu at gmail.com> wrote:
> > Hi there,
> >
> > Here is a patch which fixes the #844 ticket.
>
> lines 31 and 38 of the patch contain trailing whitespace.
> before committing you can use:
> git diff --check
>
> - filename = QFileDialog::getSaveFileName(this, tr("Save file as"),
> default_filename,
> - tr("Subsurface XML files (*.ssrf *.xml *.XML)"));
>
> (1) i know the original wasn't either...
>
> +
> + QFileDialog selection_dialog(NULL, tr("Save file as"), default_filename,
> + tr("Subsurface XML files (*.ssrf *.xml *.XML)"));
> +
>
> (2)...but the second line - tr(....) should be preferable indented
> with spaces like so:
> (should be viewed with a monospace font)
>
> QFileDialog selection_dialog(NULL, tr("Save file as"), default_filename,
>                              tr("Subsurface XML files (*.ssrf *.xml
> *.XML)"));
>
> or with a single tab.
>
> NULL for parent in QFileDialog seems to work, but any reason to change
> that?
> everywhere else in mainwindow.cpp we use "this".
>
> other than these two small remarks, the change seems about right.
>
> lubomir
> --
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150321/b4f8c15e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Implement-handler-for-cancel-button-of-Save-As-dialo.patch
Type: text/x-patch
Size: 1573 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150321/b4f8c15e/attachment.bin>