[PATCH] fixed #404 Corrects volumes of cylinders

Dirk Hohndel dirk at hohndel.org
Mon Mar 23 10:30:47 PDT 2015


On Mon, Mar 23, 2015 at 10:46:45PM +0530, Harshal Jalan wrote:
> So what  would be the correct way to solve this bug?
> 
> One way that I can think of is to edit tank_info_t to contain the
> conversion factor between the internal volume and the air volume of the
> cylinder.

The problem is that there is no one single correct wet volume.
Different vendors have different volumes. Just like not all 10 liter tanks
actually have 10000ml wet volume. If a user knows (and cares about) the
exact wet volume of their cylinder, they need to create a custom cylinder
and use that.

Anyone who simply knows that they dive operator claimed "this was an AL80"
can use our AL80 cylinder which will give them the correct values given an
assumed gas volume and working pressure.

/D


More information about the subsurface mailing list