[PATCH] Save more planner settings into prefs

Lubomir I. Ivanov neolit123 at gmail.com
Wed Mar 25 05:32:36 PDT 2015


On 25 March 2015 at 02:34, Gaetan Bisson <bisson at archlinux.org> wrote:
> [2015-03-24 14:30:57 -1000] Gaetan Bisson:
>> The new code in subsurfacestartup.c takes care of initializing those
>> settings, so there is no need to set default values for the widgets in
>> plannerSettings.ui .
>
> Note that only two of those five widgets were given explicit default
> values in plannerSettings.ui: one "true" and the other "false". That
> seemed really inconsistent to me, on top of being deprecated by the new
> code in subsurfacestartup.c, so I did not think twice about removing
> them... :)
>

Gaetan,
it's usually best to put a sentence or two in the commit message about
such side changes s well, because as you can see i though it's some
sort of residue from a test case. :-)

thanks for the explanation
lubomir
--


More information about the subsurface mailing list