[PATCH] Better solves Bug#860

Thiago Macieira thiago at macieira.org
Wed Mar 25 17:25:26 PDT 2015


On Saturday 21 March 2015 16:05:44 Lubomir I. Ivanov wrote:
> On 20 March 2015 at 22:40, Abhinav Agarwal <aagarwal.gtr at gmail.com> wrote:
> > While exporting a divelog to xml/ssrf, if given filename contains a dot it
> > doesnt get saved as intended. for eg: if given filename is
> > 'divelog.first' it should get saved as 'divelog.first.ssrf' but it gets
> > saved as 'divelog.first'. This happens only on linux and not on windows.
> > If you were to do the same on windows it would get saved as
> > 'divelog.first.xml'. This patch solves the issue. It is syntactically
> > better than the previous patch I submitted.
> hello,
> 
> for the message body, your patch still has:
> Content-Transfer-Encoding: base64
> 
> it makes the actual contents unreadable until it's applied (i.e. "git
> am" decodes it). you should look into a way to fix that e.g. use "git
> format-patch" and "git send-email" with their proper options.
> 
> other than that the change seems OK.

He did use git send-email. From the headers:

X-Mailer: git-send-email 2.1.0

It's unlikely that git-send-email decided to encode in Base64, so it must have 
been an MTA along the way.

I don't think there's anything he can do.
-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358



More information about the subsurface mailing list