tags and multi dive edit

Miika Turkia miika.turkia at gmail.com
Sat May 2 15:31:32 PDT 2015

of course :) Even better than I first thought.


> On 02 May 2015, at 18:22, Dirk Hohndel <dirk at hohndel.org> wrote:
>> On Sat, May 02, 2015 at 06:10:50PM -0400, Miika Turkia wrote:
>> the logic sounds good to me. A question remains, what to do when adding
>> a tag that already exists in one dive and then removing it, before
>> accepting the changes. imo the original tag should remain, I just wonder
>> how many other corner cases. I won't be able to test the patch until
>> next week...
> So the logic is only applied when you click "Accept". Nothing happens
> while you type - that's the whole point of having the displayed_dive.
> It takes all the tag that the current_dive has and compares them to what's
> displayed when you click Accept. And it calculates the changes from that
> (what you added, what you deleted). And then makes the corresponding
> changes to the selected dives
> /D

More information about the subsurface mailing list