GSoC - Customizable print formats

[Tomaz Canabrava]

On Mon, May 4, 2015 at 11:04 AM, Lubomir I. Ivanov <neolit123 at gmail.com>
wrote:

> CCing the mailing list.
>
> On 4 May 2015 at 02:23, Gehad <gehadelrobey at gmail.com> wrote:
> > On 05/02/2015 07:14 PM, Lubomir I. Ivanov wrote:
> >> On 29 April 2015 at 02:00, Gehad <gehadelrobey at gmail.com> wrote:
> >>>
> >>> This is my fork:
> >>> https://github.com/Gehadelrobey/subsurface
> >>> I'll push to 'custom-print' branch and rebase it with master regularly.
> >>>
> >>
> >> hello Gehad,
> >> here are some comments on the two commits that i see.
> >>
> >>
> https://github.com/Gehadelrobey/subsurface/commit/781f0f98167096c045df1426667078962b96f101
> >>
> >> CSS coding style related
> >>
> >> .innerContainer {
> >>     height: 85%;
> >>     ...
> >> }
> >>
> >> note that:
> >> - the opening brace is on the same line as the class name
> >> - "height : ..." should be without space after "height" and before
> >> ":". space only after ":".
> >>
> >
> > Fixed and pushed to the branch.
>
> thanks, looks good.
>
> >
> >>
> https://github.com/Gehadelrobey/subsurface/commit/af2376ff2e9277d938d29c95c3999443f8023c56
> >>
> >> i need to see if if this works from me (on win32):
> >> find_package(Grantlee5)
> >>
> >> for instance, it finds marble using find_package, but the resulted
> >> variables were bogus if i recall correctly.
> >>
> >> even if AFAIK both libraries don't use pkg-config we may have to add
> >> the optional:
> >> GRANTLEE_FROM_PKGCONFIG
> >> MARBLE_FROM_PKGCONFIG
> >>
> >
> > I changed the cmake file a little bit.
> >
> > -find_package(Grantlee5)
> > -set(GRANTLEE_LIBRARIES Grantlee5::Templates)
> > +if(GRANTLEE_FROM_PKGCONFIG)
> > +       pkg_config_library(LIBGRANTLEE libgrantlee-templates5 REQUIRED)
> > +       set(GRANTLEE_LIBRARIES "")
> > +else()
> > +       find_package(Grantlee5)
> > +       set(GRANTLEE_LIBRARIES Grantlee5::Templates)
> > +endif()
> >
> > I installed libgrantlee-dev but couldn't find the package with
> > pkg-config, So I didn't succeed to link subsurface to libgrantlee5.
> >
> >
>
> that's probably because marble and grantlee AFAIK don't use pkg-config.
>
> like i said:
> > unlike cmake, qmake allowed "PKGCONFIG += libmarble", which was very
> handy.
>
> i need to figure a way how to approach the cmake issue before i
> continue reviewing, as i simply can't compile ATM.
> then i also need to look into the rest of the patches that you have pushed.
>

If you use windows - Open cmake-gui and point the source dir ( the one that
has CMakeLists.txt ) on the  project line edit,
and select your build dir.

>From the drop down menu, select your generator ( I'm guessing it's a
mingw-generator )

Then click configure
It will fail, but it will show you what failed, then you can click on the
failed fields to point it to the right location.

each of those failed fields is a -DFAILED_FIELD_NAME=c:/path/to/something
that you can add to the command line if you prefer .

>
> lubomir
> --
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150504/6815c276/attachment.html>