Allow replanning of logged dives

[Robert C. Helling]

Hi everybody,

> Hmm, "Edit dive in planner"
> which begs the question... why ARE we editing the dive in the planner and
> not in the simpler dive edit mode. I'm not saying this is wrong (and I'm
> taking the patch), I'm just asking a questions…

Hmm. Dunno. Maybe „Edit profile in planner“ (and also „edit profile“ would be more accurate since we edit dives in all other places as well. Feel free to change the menu entry to something more sensible. Or are you really asking the question „Why are edit dive and the planner two different things?“? Maybe we should merge them and rather turn on planning with a checkbox?

[after writing the previous paragraph, /me actually tried out add dive/edit dive for the first time in quite a while. There is an obvious difference to the planner: In add/edit dive the main window standard tabs with notes etc are visible]

But maybe we should merge edit dive and edit dive in planner? Or simply get rid of „edit dive“ (and rather add a checkbox to the planner that turns off planning?

> This is 2/3 of what I was hoping for.
> I was also thinking that if the dive points go all the way back to the
> surface (which they most likely will when you just edited an existing dive
> and didn't ask the planner to get you back safely), then we shouldn't add
> the disclaimer and runtime table at all...

This is addressed in the attached patch. It only adds disclaimer and runtime table if the planner actually added stops.

Best
Robert
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Only-add-disclaimer-and-runtime-table-if-we-added-deco.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150509/50971259/attachment.txt>