Allow replanning of logged dives
dirk at hohndel.org
Mon May 11 09:41:51 PDT 2015
On Sat, May 09, 2015 at 10:07:06PM +0200, Robert C. Helling wrote:
> Hi everybody,
> > Hmm, "Edit dive in planner"
> > which begs the question... why ARE we editing the dive in the planner and
> > not in the simpler dive edit mode. I'm not saying this is wrong (and I'm
> > taking the patch), I'm just asking a questions…
> Hmm. Dunno. Maybe „Edit profile in planner“ (and also „edit profile“ would be more accurate since we edit dives in all other places as well. Feel free to change the menu entry to something more sensible. Or are you really asking the question „Why are edit dive and the planner two different things?“? Maybe we should merge them and rather turn on planning with a checkbox?
> [after writing the previous paragraph, /me actually tried out add dive/edit dive for the first time in quite a while. There is an obvious difference to the planner: In add/edit dive the main window standard tabs with notes etc are visible]
> But maybe we should merge edit dive and edit dive in planner? Or simply get rid of „edit dive“ (and rather add a checkbox to the planner that turns off planning?
So the real difference is that when you edit a dive we normally want to be
in regular edit more where you can edit notes, tags, buddies, etc.
We can take this in two directions:
a) allow both modes, edit and replan.
Have consistent menues and add your clever algorithm that turns an
existing dive into something the user can modify. In "edit" mode I'd keep
a copy of the original divecomputer around and have an edited version
added. This way we don't lose data.
b) merge the two modes
that might actually be the harder thing to do. Because we need to be able
to switch between the planner stuff and the regular notes tab. And we
still need to figure out what we do with a regular dive...
> > This is 2/3 of what I was hoping for.
> > I was also thinking that if the dive points go all the way back to the
> > surface (which they most likely will when you just edited an existing dive
> > and didn't ask the planner to get you back safely), then we shouldn't add
> > the disclaimer and runtime table at all...
> This is addressed in the attached patch. It only adds disclaimer and
> runtime table if the planner actually added stops.
More information about the subsurface