small contributions for today

Dirk Hohndel dirk at
Sun May 17 14:08:47 PDT 2015

On Sun, May 17, 2015 at 05:16:04PM -0300, Tomaz Canabrava wrote:
> plus a few more. :)
> I ll also send a bunch more patches today
> but now, lunch and movie. :D

Enjoy the movie. And thanks for being back working on Subsurface.

Quick question - did you build test these patches? There was a missing
#include and a stray letter 'a' - both of which made the build fail quite
obviously and reproducably...

And once I fix those, I can rather easily reproduce a crash:
Open dive file. Click Location-manage. Pick a site. Click close. Click
Location-manage again. BOOM. I added a patch that seems to make sense, but
since not a lot of the code is hooked up yet, I'm not sure this is what we
want in the end.

I was debating whether to add this to master, but I'd rather have you
continue on top of this than on top what you had sent, so everyone else,
be careful, right now master has some issues :-/


More information about the subsurface mailing list