small contributions for today

[Tomaz Canabrava]

Ups. I will fix those right away -  and yes I tested closing and reopening
the dive site a bunch of times, don't know what can be the issue. Let me
take a look

On Sun, May 17, 2015, 18:09 Dirk Hohndel <dirk at hohndel.org> wrote:

> On Sun, May 17, 2015 at 05:16:04PM -0300, Tomaz Canabrava wrote:
> > plus a few more. :)
> > I ll also send a bunch more patches today
> > but now, lunch and movie. :D
>
> Enjoy the movie. And thanks for being back working on Subsurface.
>
> Quick question - did you build test these patches? There was a missing
> #include and a stray letter 'a' - both of which made the build fail quite
> obviously and reproducably...
>
> And once I fix those, I can rather easily reproduce a crash:
> Open dive file. Click Location-manage. Pick a site. Click close. Click
> Location-manage again. BOOM. I added a patch that seems to make sense, but
> since not a lot of the code is hooked up yet, I'm not sure this is what we
> want in the end.
>
> I was debating whether to add this to master, but I'd rather have you
> continue on top of this than on top what you had sent, so everyone else,
> be careful, right now master has some issues :-/
>
> /D
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150517/96f32d1b/attachment.html>