[PATCH] Re: Issue with dive merge

Robert Helling helling at atdotde.de
Mon May 18 01:53:49 PDT 2015

> On 18.05.2015, at 10:00, Miika Turkia <miika.turkia at gmail.com> wrote:
> On Mon, May 18, 2015 at 10:56 AM, Robert Helling <helling at atdotde.de <mailto:helling at atdotde.de>> wrote:
>> Hi Christophe,
>> On 18.05.2015, at 09:41, Christophe Démaret <christophe at demaret.eu> wrote:
>> Expected: Dives are merged
>> What actually happens: Nothing. Dives are not merged, no error message, no
>> crash.
>> Subsurface only merges dives with less than 30 minutes interval between
>> them. Change the starting time of the dive 178 by a little bit and the dives
>> will be merged.
>> Maybe instead of silently failing, we should give an error message or better
>> ask the user if she still wants to merge the dives? Is there a situation
>> where we actually want to fail silently (e.g. merging many dives but amongst
>> those one the ones that make sense?!?)
> I vote for merging the dives, as the user has explicitly requested
> this to occur. However, a confirmation dialog when the interval is
> more than 30 minutes would make sense. Just make sure there are no
> multiple dialogs when merging multiple dives.

OK, here is a patch that does this.


Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150518/752b1196/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Ask-user-about-merging-dives-more-than-30m-apart.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150518/752b1196/attachment.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150518/752b1196/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150518/752b1196/attachment.sig>

More information about the subsurface mailing list