[PATCH] Re: Issue with dive merge

[Christophe Démaret]

Thanks guys for your help, I changed the start time by 2 minutes and now
it's solved.
Agreed on the usability point so happy to see it will be fixed.
Thanks again for this awesome piece of software.

Christophe

2015-05-18 10:53 GMT+02:00 Robert Helling <helling at atdotde.de>:

>
> On 18.05.2015, at 10:00, Miika Turkia <miika.turkia at gmail.com> wrote:
>
> On Mon, May 18, 2015 at 10:56 AM, Robert Helling <helling at atdotde.de>
> wrote:
>
> Hi Christophe,
>
> On 18.05.2015, at 09:41, Christophe Démaret <christophe at demaret.eu> wrote:
>
>
> Expected: Dives are merged
> What actually happens: Nothing. Dives are not merged, no error message, no
> crash.
>
>
> Subsurface only merges dives with less than 30 minutes interval between
> them. Change the starting time of the dive 178 by a little bit and the
> dives
> will be merged.
>
> Maybe instead of silently failing, we should give an error message or
> better
> ask the user if she still wants to merge the dives? Is there a situation
> where we actually want to fail silently (e.g. merging many dives but
> amongst
> those one the ones that make sense?!?)
>
>
> I vote for merging the dives, as the user has explicitly requested
> this to occur. However, a confirmation dialog when the interval is
> more than 30 minutes would make sense. Just make sure there are no
> multiple dialogs when merging multiple dives.
>
>
> OK, here is a patch that does this.
>
> Best
> Robert
>
>
>
> --
>
> .oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
> Robert C. Helling     Elite Master Course Theoretical and Mathematical
> Physics
>                       Scientific Coordinator
>                       Ludwig Maximilians Universitaet Muenchen, Dept.
> Physik
>                       Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
>                       http://www.atdotde.de
>
> Enhance your privacy, use cryptography! My PGP keys have fingerprints
> A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
> DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F
>
>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150518/72bdb1eb/attachment-0001.html>