GSoC - Customizable print formats

[Tomaz Canabrava]

On Wed, May 27, 2015 at 2:09 PM, Gehad Elrobey <gehadelrobey at gmail.com>
wrote:

>
>
> On Tue, May 26, 2015 at 12:55 PM, Lubomir I. Ivanov <neolit123 at gmail.com>
> wrote:
>
>> On 25 May 2015 at 21:26, Gehad Elrobey <gehadelrobey at gmail.com> wrote:
>> > Hello Lubomir,
>> >
>> > As GSoC coding period have begun, I wanted to update you with my
>> progress
>> > till now, I've pushed some more commits to my git branch, I will push
>> some
>> > more commits on the weekend as I am having my finals exams now. BTW
>> Have you
>> > managed to build subsurface with Grantlee yet or you still getting the
>> same
>> > linking error?
>> >
>>
>> alright, i'm able to build now.
>>
>> please, merge the attached patch into your repository and let me know
>> if you have any issues with it.
>> also remove the NEW_PRINTING macro and CustomPrintDialog (more comments
>> bellow).
>>
>> per-commit short reviews. read from bottom to top:
>>
>> ---------------
>>
>> 9b2701e Add Progress bar to custom print dialog
>>
>> see da5ce64
>>
>> 3a37e57 Remove unused variable
>>
>> should be rebased. the code which it touches is WIP.
>>
>> ff97353 Open custom print dialog if NEW_PRINTING is defined
>>
>> see da5ce64
>>
>> da5ce64 Create the new custom print dialog
>>
>> i think you should just modify the current print dialog. adding more
>> files creates noise.
>> it was already discussed that master will have a "broken" printing
>> module while this GSoC task is WIP.
>>
>>
> I though that I ll have to use the macro until the printing work is
> finished so that we can continue building subsurface without breaking the
> current module, I ll fix this.
>
>
>> 823d86a Add "NEW_PRINTING" Cmake variable
>>
>> like Dirk pointed out we are going to make grantlee a hard dependency
>> for the printing to work. thus if cmake cannot find grantlee we just
>> need to disable the printing.
>> instead of the NEW_PRINTING cmake option rename it to NO_PRINTING (+
>> change the description) which sets the NO_PRINTING pre-processor macro
>> if "the user says so" or if grantlee is not found.
>>
>> ef99f65 Add Printer class that holds the rendering logic.
>>
>> this is WIP and is good to go as the basis for the future logic of
>> having user printer dialog selectable properties.
>>
>> 78fcd53 Add TemplateLayout class
>>
>> asked the same before; any comments on why we need a local Dive object?
>> i highly doubt this will reach master as is.
>>
>
> I needs the local dive object as Grantlee::Context is initialized
> by QVariantList<Dive> which contains all selected dives information, I have
> also checked the existing dive class at "models.h" and the class was
> missing many fields that will be needed by the printing module, AFAIK the
> class in models.h is currently used in the dive list view only.
>

What you need on the models? I can add them.


>
> --
> regards,
>
> Gehad
>
>
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150527/76fd5079/attachment.html>