[PATCH 2/2] subsurfacestartup.c: don't double free 'default_filename'

Lubomir I. Ivanov neolit123 at gmail.com
Tue Nov 3 04:29:36 PST 2015


From: "Lubomir I. Ivanov" <neolit123 at gmail.com>

'default_filename' is obtained from system_default_filename()
but system_default_filename() returns a static pointer
the HEAP memory of which is handled in main().

Remove the free() for 'default_filename' free_prefs()
to prevent a double free().

Signed-off-by: Lubomir I. Ivanov <neolit123 at gmail.com>
---
 subsurface-core/subsurfacestartup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/subsurface-core/subsurfacestartup.c b/subsurface-core/subsurfacestartup.c
index 0bde2a0..13cbbfa 100644
--- a/subsurface-core/subsurfacestartup.c
+++ b/subsurface-core/subsurfacestartup.c
@@ -311,7 +311,6 @@ void copy_prefs(struct preferences *src, struct preferences *dest)
  */
 void free_prefs(void)
 {
-	free((void*)prefs.default_filename);
 	free((void*)prefs.default_cylinder);
 	free((void*)prefs.divelist_font);
 	free((void*)prefs.cloud_storage_password);
-- 
1.7.11.msysgit.0



More information about the subsurface mailing list