[PATCH]es: mobile ui improvements
Sebastian Kügler
sebas at kde.org
Sat Nov 7 09:09:07 PST 2015
A whole bunch of improvements to the mobile ui ahead.
This series of patches implements does the following:
- build fix for Android (#0001)
- layout and spacing improvements (#0006, #0009, #0010), these use
common values for spacing in the layout, and result in a more organized
appearance of the UI.
- label fixes (#0011), this one especially takes care of the login dialog for the
cloud service actually fitting on the screen.
- overall navigation (#0008), this factors out top bar into its own file, and
makes it a static element, rather than a layout item inside the pages. The
navigation button is now a little smarter and as a result, this culls quite some
redundant code.
- a welcoming startpage (#0004), on first startup, the dive list is empty. Instead
of greeting the newuser with a large empty space, we offer direct access to
importing dives and use the empty space more wisely.
- QML files all go into the qml/ subdirectory (#0003), this makes it a bit more
organized, and we don't mingle "data" with compiled code too much. It also
makes it a bit easier to keep the qrc file up to date.
- indentation and dead code cleanups (#0002, #0005, #0007)
These changes, along with the earlier patches make the Android app start to
look pretty good, there are a few "functional shortcomings" right now,
downloading dives from the cloud storage is broken, and since I've merged
master, no dives are shown anymore (I wonder if I broke it, or if it happened
to master...).
I've only reworked the list and cloud login pages so far, the other parts of the
functionality I couldn't really test yet -- I only got the Android build going
yesterday and importing data is broken. The dive details page needs quite a bit
of work to fit on a phone's screen in portrait, and so do the add-dive-manually
and download-from-computer pages.
I'm really quite happy with tomaz' refactoring, the startup time has much
improved, and we drag a lot less unneeded bits around, it seems.
Overall progress is pretty good, too: The dpi and sizing problems are fixed
navigation logic is improved, the code organization is a bit more scalable and
it starts to look purty. Much more work ahead, but it shows promise.
--
sebas
Sebastian Kügler | http://vizZzion.org | http://kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Recognize-Android-as-CMAKE_SYSTEM_NAME.patch
Type: text/x-patch
Size: 1211 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-indentation-in-qrc-file.patch
Type: text/x-patch
Size: 1317 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-organize-qml-files-in-subdirectories.patch
Type: text/x-patch
Size: 60668 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Improve-layout-of-login-dialog.patch
Type: text/x-patch
Size: 2190 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Improve-1st-start-experience.patch
Type: text/x-patch
Size: 3970 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Clean-up-dead-code-in-units.patch
Type: text/x-patch
Size: 873 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Remove-hard-coded-size-from-label-component.patch
Type: text/x-patch
Size: 954 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Rejig-navigation.patch
Type: text/x-patch
Size: 7938 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-tighter-margins-on-start-page.patch
Type: text/x-patch
Size: 902 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Improve-TopBar-and-login-window-layout.patch
Type: text/x-patch
Size: 3500 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-Improve-labels-in-login-dialog.patch
Type: text/x-patch
Size: 1021 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151107/c7869dbf/attachment-0021.bin>
More information about the subsurface
mailing list