[PULL REQUEST] warning fixes
Dirk Hohndel
dirk at hohndel.org
Sat Nov 7 22:24:27 PST 2015
On Sun, Nov 08, 2015 at 12:00:47AM +0200, Lubomir I. Ivanov wrote:
> some general cleanup of warnings.
>
> i always check for #ifdefs before removing an unused variable, but please
> let me know if i messed up somewhere or if something looks wrong.
I didn't see anything wrong with these. Thanks for doing them. There is
one where I decided to rework the commit message (you had comments after
your SOB), other than that they looked fine.
/D
>
> -------
> The following changes since commit dab207a8c84ca0621a8a3cabd0b911e60347537d:
>
> Subsurface-mobile: load preferences after org is set up (2015-11-07 11:25:12 -0800)
>
> are available in the git repository at:
>
> git at github.com:neolit123/subsurface.git warnings
>
> for you to fetch changes up to 70520af5afce842cc5e302cd1d254dd89d894565:
>
> abstractpreferenceswidget.cpp: fix argument warning (2015-11-07 23:20:09 +0200)
>
> ----------------------------------------------------------------
> Lubomir I. Ivanov (20):
> desktop-main.cpp: fix unused 'application' variable
> btdeviceselectiondialog.cpp: fix unused variable
> locationinformation.cpp: fix unused variable
> divelogimportdialog.cpp: declare an enum as type
> subsurfacewebservices.cpp: remove unused FILE variable
> subsurfacewebservices.cpp: make sure 'changed' is not unused
> mainwindow.cpp: remove unused variable 'diveSitePictures'
> facebook_integration.cpp: add return statement to a 'bool' method
> maintab.cpp: remove unused variable
> diveshareexportdialog.cpp: fix an argument order warning
> divelocationmodel: fix some signed/unsigned warnings
> preferences_network.cpp: remove some unused 'reply' variables
> profilewidget2.cpp: remove unused variables
> filtermodels.cpp: fix an argument order warning
> diveplannermodel.cpp: move unused variables into a commented section
> profile.c: mark get_local_sac() as unused
> profile.c: remove unused variables
> preferencesdialog.cpp: silence a switch warning
> dive.c: remove unused variable
> abstractpreferenceswidget.cpp: fix argument warning
>
> desktop-widgets/btdeviceselectiondialog.cpp | 3 +--
> desktop-widgets/divelogimportdialog.cpp | 4 ++--
> desktop-widgets/diveshareexportdialog.cpp | 4 ++--
> desktop-widgets/locationinformation.cpp | 1 -
> desktop-widgets/maintab.cpp | 2 +-
> desktop-widgets/mainwindow.cpp | 2 --
> desktop-widgets/plugins/facebook/facebook_integration.cpp | 2 +-
> desktop-widgets/preferences/abstractpreferenceswidget.cpp | 2 +-
> desktop-widgets/preferences/preferences_network.cpp | 8 ++++----
> desktop-widgets/preferences/preferencesdialog.cpp | 1 +
> desktop-widgets/subsurfacewebservices.cpp | 2 +-
> profile-widget/profilewidget2.cpp | 3 +--
> qt-models/divelocationmodel.cpp | 8 ++++----
> qt-models/divelocationmodel.h | 2 +-
> qt-models/diveplannermodel.cpp | 4 ++--
> qt-models/filtermodels.cpp | 4 ++--
> subsurface-core/dive.c | 1 -
> subsurface-core/profile.c | 9 ++++-----
> subsurface-desktop-main.cpp | 1 +
> 19 files changed, 29 insertions(+), 34 deletions(-)
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
More information about the subsurface
mailing list