[PATH] fix broken mac build on old clangs.

Thiago Macieira thiago at macieira.org
Sun Nov 8 19:31:10 PST 2015


On Sunday 08 November 2015 22:12:19 Tomaz Canabrava wrote:
>  if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
> -       set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu11 ")
> -       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
> +       set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99 ")
>  elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang")
> -       set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu11 ")
> -       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
> +       set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99 ")

Why? Anyone using Clang has a recent enough version of it that it supports 
C++11.

GCC 5.0 and Clang 3.7 switched C mode to C11 by default (your patch reverts 
that to C99); GCC 6.0 is switching to C++14 by default.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358



More information about the subsurface mailing list