something is wrong with the "facebook_integration" module

[Lubomir I. Ivanov]

hey Tomaz,

cmake version 3.2.0-rc2, native Windows.

with the latest master i get thousands of "undefined references" errors.

CMakeFiles\facebook_integration.dir/objects.a(facebookconnectwidget.cpp.obj):
In function `ZN15FacebookManager8sendDiveEv':
C:/dev/subsurface/desktop-widgets/plugins/facebook/facebookconnectwidget.cpp:223:
undefined reference to `ProfileWidget2::setToolTipVisibile(bool)'
C:/dev/subsurface/desktop-widgets/plugins/facebook/facebookconnectwidget.cpp:225:
undefined reference to `ProfileWidget2::setToolTipVisibile(bool)'
../../../subsurface-core/libsubsurface_corelib.a(parse-xml.c.obj): In
function `visit_one_node':
C:/dev/subsurface/subsurface-core/parse-xml.c:1852: undefined
reference to `xmlIsBlankNode'
../../../subsurface-core/libsubsurface_corelib.a(parse-xml.c.obj): In
function `preprocess_divelog_de':
C:/dev/subsurface/subsurface-core/parse-xml.c:2005: undefined
reference to `xmlCreateMemoryParserCtxt'
C:/dev/subsurface/subsurface-core/parse-xml.c:2006: undefined
reference to `xmlStringLenDecodeEntities'
../../../subsurface-core/libsubsurface_corelib.a(parse-xml.c.obj): In
function `parse_xml_buffer':
C:/dev/subsurface/subsurface-core/parse-xml.c:2021: undefined
reference to `xmlReadMemory'
C:/dev/subsurface/subsurface-core/parse-xml.c:2032: undefined
reference to `xmlDocGetRootElement'
C:/dev/subsurface/subsurface-core/parse-xml.c:2037: undefined
reference to `xmlFreeDoc'
../../../subsurface-core/libsubsurface_corelib.a(parse-xml.c.obj): In
function `dm4_dive':
<more....>

i saw your recent patch;
"Link the facebook plugin against the subsurface_interface"

to me it looks like that in my case the facebook module is not linked
both to the core and the desktop-widget modules.

if set the following in the cmake CMD line:
-DDISABLE_PLUGINS=1 -DFBSUPPORT=1
all is good.

any idea what is causing that? perhaps my older cmake...
BTW, why did you decide to introduce plugins in Subsurface? are there
benefits over any possible complications that the plugins may
introduce.

also, unless i'm mistaken, if a plugin is static linked against the
same .a modules that the executable is linked (core, profile,
desktop-widges, etc) aren't we are going to distribute the same code
twice and the plugin size is going to be quite large?

lubomir
--