[PATCH] mobile: divedetails page etc. improvements
Dirk Hohndel
dirk at hohndel.org
Wed Nov 11 20:45:53 PST 2015
On Thu, Nov 12, 2015 at 01:27:54AM +0000, Sebastian Kügler wrote:
> Heya,
>
> Some more work on the mobile version, especially on the divelist and details.
Great!
> - bugfix for label overflow in dive list
> - don't create the expensive profilewidget for every frame painted by the item
> - kill warnings due to conditional build of subsurface-mobile (#0006)
> - other cleanups (#0001, #0003)
> - further layout and styling improvements (all the other patches)
It's coming along. How hard will it be to swipe sideways from dive to dive
when in dive detail mode? So I tap on one of the dives and I just swipe
left and right to get to the previous / next dive instead of having to go
back to the dive list between dives?
> Most visible is probably the rework of the dive profile page, aside various text
> display fixes.
Yes, this looks nice. Just the profile needs more work. Lubomir and Tomaz
are most likely able to help you with the magic of making that work
better.
I took the patches as submitted, including the CloudStorage.qml - you can
just update that in your next series. That seemed easier than asking you
to refactor and resubmit - I really want to keep the momentum going...
As you have noticed I'm adding the location service to Subsurface-mobile
so that we can drop the companion apps and have it all integrated into one
app...
/D
More information about the subsurface
mailing list