Mac OSX SHEARWATER problems,

[Lubomir I. Ivanov]

On 13 November 2015 at 07:43, Willem Ferguson
<willemferguson at zoology.up.ac.za> wrote:
> abort() called
> *** error for object 0x60000008edd0: pointer being freed was not allocated
>
>
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0   libsystem_kernel.dylib         0x00007fff92e95286 __pthread_kill + 10
> 1   libsystem_c.dylib             0x00007fff861209b3 abort + 129
> 2   libsystem_malloc.dylib         0x00007fff8bf721cb free + 428
> 3   org.subsurface-divelog         0x0000000101478794 free_prefs + 20
> 4   org.subsurface-divelog         0x00000001011efe8d main + 2301
> 5   org.subsurface-divelog         0x00000001011ef584 start + 52
>

the report is obvious, but on a quick look @ the source i can't pin
point the exect free() call which is the problem one.
all preferences seem to be allocated with with string_copy() and if a
preference is NULL free() should not be a problem.

i can't debug that on Win32, because my fake console exits too early.
the proposed patch is the following: make free_prefs() a NOP, until we
refactor the global preferences.
the one-time leaks won't do much harm.

patch attached.

lubomir
--

P.S. if someone has means to debug this properly, please go ahead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-subsurfacestartup.c-leave-free_prefs-empty.patch
Type: text/x-patch
Size: 1496 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151113/9d3e8fbc/attachment.bin>