[PATCH] Re: "one dive" printout - not correct HTML interpretion for dive from planner

Robert Helling helling at atdotde.de
Tue Nov 17 02:20:41 PST 2015


> On 17.11.2015, at 08:07, K. pestophagous Heller <pestophagous at gmail.com> wrote:
> 
> to clarify:  nesting tables was not my worry. my worry is regarding a
> single orphan tag (which happens to be '</table>') getting into the
> middle of an outer table. i don't know what to call this, but i
> wouldn't call it nested tables.
> 
> one path through add_plan_to_notes introduces (essentially) line 3 in
> the middle of what would otherwise be well-formed html:
> 
> 1: <table> <!-- well formed -->
> 2: ... other content ...
> 3:        </table>  <!-- missing a rightful matching opener -->
> 4: ... other content ...
> 5: </table> <!-- this was once well formed -->
> 
> this prematurely closes the outer table, which has weird implications
> for all that other content. but since the outcome you observed cannot
> be explained by a prematurely-closed table, then my notes are nothing
> but a red herring this time. not helpful :(


Rather than worrying how the parser will handle unmatched closing tags, we should just make sure they don’t appear. This patch does this.

Best
Robert


--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151117/660bd245/attachment-0002.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Only-close-html-tags-if-they-were-opened-before.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151117/660bd245/attachment-0001.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151117/660bd245/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151117/660bd245/attachment-0001.sig>


More information about the subsurface mailing list