[PATCH 0/7] fix some warnings for the mobile version
Dirk Hohndel
dirk at hohndel.org
Wed Nov 18 19:29:42 PST 2015
On Wed, Nov 18, 2015 at 11:46:53PM +0200, Lubomir I. Ivanov wrote:
> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>
> Fix some warnings when compiling the mobile version with -Wall.
> Also fix the ApplicationWindow crash.
>
> Lubomir I. Ivanov (7):
>
> gpslocation.cpp: fix unused variable warning
> gpslocation.cpp: fix warning about missing return statement
> qmlmanager.cpp: fix unused variable warning
For the three above I ended up not using your commits that hid the
warnings but instead fix the underlying problem which were all bugs (or at
least oversights) in our code...
> gpslocation.cpp: fix signed vs unsinged int comparison warning
> libdivecomputer.h: fix warning with DC_VERSION on Win32
> subsurface-mobile-main.cpp: fix unused variable 'application'
>
> ^ some generic warning fixes in the above patches.
Those three I took.
> main.qml: fix crash on native Win32 desktop
>
> ^ Sebastian said that he will implement this one, so ignore if he
> already has the change on his end.
For this one I'll wait to hear from Sebastian.
Thanks, Lubomir
/D
More information about the subsurface
mailing list