[mobile ui] navigation rework

Dirk Hohndel dirk at hohndel.org
Sun Nov 29 13:25:10 PST 2015


On Sun, Nov 29, 2015 at 05:41:45PM +0000, Sebastian Kügler wrote:
> Marco Martin (a Plasma colleague are currntly sitting at my place and hacking
> on subsurface and the components it's using, with the goal to straighten the
> mobile components out that we're using as a base for subsurface mobile. The
> results are already quite nice. We can now run on top of a set of pretty
> minimal components, so we do not have to roll our own solutions for Theme and
> Units anymore.

The mobile components look nice indeed. And I like being able to reuse
things that an upstream is maintaining and improving.

> These components come in the form of a bunch of qml files, they're included in
> the qrc file, and loaded dynamically as QML import plugin.
> 
> User visible changes are:
> 
> - broken header coloring (you didn't think this would work without a hitch,
> right? An easy to fix one, but I'm already sitting on too many large patches,
> so I'd rather already send these current ones in and work on the remaining
> regressions in the meantime)

Definitely the right approach at this point in the release cycle

> - tablet mode, the UI now can use two columns aside of each other (haven't
> extensively tested this, so it may need a bit of tweaking)

That's what I get when testing on the desktop - is there a way to manually
tell it to use the phone UI instead so I can see how both of them look?

Ahh, making the window narrower seems to do the trick.

> - more complete set of components we're using throughout our ui -- the work on
> that is now shared with Plasma
> - The various GPS options have moved into their own submenu, it's a lot easier
> to scan this way

I don't see this. The menu looks the same to me?

> We're still on it, so there are more patches coming up.

Cool.

> One thing that worries me a bit is that we're going back to ApplicationWindow,
> which might mean Lubomir's headaching windows crashers return. Testing that
> would be much appreciated.

It works for me on Linux. I think Lubomir is the only one testing on
Windows. Possibly we'll have to make this platform specific?

> Patch #0004 is missing from this email, it's an image used for the navigation
> drawer, and turns out pretty big, and I dunno if you can actually apply it
> sent like this. Rather pull the whole branch from github.

The mailing list takes fairly large emails, but pull requests are fine.
I consider you the maintainer of the mobile UI at this point, anyway :^)

> This patch series is also on github: git at github.com:sebasje/subsurface.git
> branch "mobilecomponents".

That's what I pulled from.

When running this on Linux I get quite a few warnings and errors and can
easily get things to crash (Add Dive - that's a known issue and not
something I'm overly worried about right now).

qrc:////imports/org/kde/plasma/mobilecomponents/Icon.qml:32:5: QML Image: Cannot open: qrc:///imports/org/kde/plasma/mobilecomponents/icons/qrc:/qml/subsurface-mobile-icon.png.svg                                                         
qrc:////imports/org/kde/plasma/mobilecomponents/GlobalDrawer.qml:98:17: QML Item: Binding loop detected for property "height"                                                                                                               
qrc:////imports/org/kde/plasma/mobilecomponents/Icon.qml:32:5: QML Image: Cannot open: qrc:///imports/org/kde/plasma/mobilecomponents/icons/distribute-horizontal-x.svg                                                                     
qrc:///qml/main.qml:244:22: Unable to assign [undefined] to double
qrc:///qml/DiveDetails.qml:39: ReferenceError: contentRect is not defined
qrc:////imports/org/kde/plasma/mobilecomponents/PageRow.qml:148:9: QML ScriptAction: qrc:////imports/org/kde/plasma/mobilecomponents/PageRow.qml:150: TypeError: Cannot read property 'page' of undefined
<Unknown File>: QML StateGroup: Can't apply a state change as part of a state definition.
<Unknown File>: QML StateGroup: Can't apply a state change as part of a state definition.
<Unknown File>: QML StateGroup: Can't apply a state change as part of a state definition.

That last one happens when I click on the black square at the bottom
(which I assume is supposed to be some cute button with a circle around
it, it just doesn't get rendered correctly.

Right now this is clearly quite raw, but I think the best course of action
is to push this into master and assume that your next patches will make
this more usable again. That seems better than keeping it outside of
master and making the delta between what you are working on and what the
rest of us have bigger and bigger.

Thanks

/D


More information about the subsurface mailing list