[mobile ui] navigation rework

[Rick Walsh]

On 30 November 2015 at 15:57, Dirk Hohndel <dirk at hohndel.org> wrote:

> Sebastian and Marco (welcome to the team, btw):
>
> Awesome. The jump forward of the mobile UI is stunning. It's fun to read
> through the commits and see the two of you work together.
>
> Thanks for the time and effort spent on Subsurface-mobile this weekend!
>
> The commits have a tiny bit of back-and-forth in them (some times things
> get added and then later deleted... maybe the various syncs with
> mobilecomponents could be merged into one...) but instead of spending time
> to artificially rewrite history into something more pleasing I figured
> "what the heck, this is awesome" and left them untouched from what you had
> in your branch. And since you didn't touch compiled code (except for
> adding the //imports) I didn't see any concern in doing this, anyway -
> this is truly just moving the mobile UI forward.
>
> On Mon, Nov 30, 2015 at 02:35:49AM +0000, Sebastian Kügler wrote:
> >
> > Pull again. We did a whole bunch of fixes in the components and the
> > applications. The regressions that you saw should be fixed, at least the
> > one we saw as well.
>
> Yes, most of the issues I saw are addressed in master now. New Android
> APKs have been uploaded for testing. Those of you with access to an
> Android device: seriously, check this out.
>

I took the bait, and installed the latest apk (4.5.2.315) from the daily
download page on my Galaxy S6 and had a play.  It really is looking great.

I did come across a few bugs you may or may not be aware of yet:

When loading dives from the cloud file, existing dives are duplicated in
the dive list (see attached screenshot), but after closing the app and
re-opening, the list is as it should be.

I managed to crash the app by:
(1) selecting a dive that didn't already have 'suit' data
(2) tapping on the 'suit' entry to go into edit mode
(3) hitting back to exit edit mode (without adding anything)
(4) hitting back to return to dive list
(5) selecting another dive in the list
(6) crash

The drawer (is that what it's called?) button at the base of the screen is
shown as a black square over a circle - see screenshot.

The GPS entry in the menu on the left of screen (when displayed) also has a
black square, where presumably an icon should be.

As Dirk mentioned:
It would be nice if the startup were faster
Sizing the displayed profile is ad-hoc (sometimes rotating the screen, then
rotating back seems to get the sizing right, but not always).

I didn't test manually adding a dive or the location service.

Cheers,

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151130/c47e9ae6/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot_2015-11-30-23-06-40.png
Type: image/png
Size: 321673 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151130/c47e9ae6/attachment-0001.png>