[PATCH] Correct sign on Divesoft Freedom timestamps

Anton Lundin glance at acc.umu.se
Sun Oct 4 05:03:49 PDT 2015


I managed somehow to miss-read and by accident told Linus that the
timestamp was signed.

It is a unsigned uint32_t, so this corrects the mistake i tricked Linus
into making.

Signed-off-by: Anton Lundin <glance at acc.umu.se>
---
 parse-xml.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/parse-xml.c b/parse-xml.c
index b2bc76f..5f4b667 100644
--- a/parse-xml.c
+++ b/parse-xml.c
@@ -3247,14 +3247,14 @@ int parse_divinglog_buffer(sqlite3 *handle, const char *url, const char *buffer,
 }
 
 /*
- * Parse a signed 32-bit integer in little-endian mode,
+ * Parse a unsigned 32-bit integer in little-endian mode,
  * that is seconds since Jan 1, 2000.
  */
 static timestamp_t parse_dlf_timestamp(unsigned char *buffer)
 {
 	timestamp_t offset;
 
-	offset = (signed char) buffer[3];
+	offset = buffer[3];
 	offset = (offset << 8) + buffer[2];
 	offset = (offset << 8) + buffer[1];
 	offset = (offset << 8) + buffer[0];
-- 
2.1.4



More information about the subsurface mailing list