[PATCH] Wrong maxdepth when splitting dives (WAS Re: 4.5 Beta 3)

Dirk Hohndel dirk at hohndel.org
Mon Oct 5 08:41:46 PDT 2015


On Mon, Oct 05, 2015 at 04:34:13PM +0100, Dirk Hohndel wrote:
> On Mon, Oct 05, 2015 at 05:19:35PM +0200, Giorgio Marzano wrote:
> > Dirk,
> > 
> > this patch should fix the wrong values in the max depth field for splitted
> > dives.
> 
> It does - I already have a more complete patch in my tree but haven't had
> a chance to push that out, yet. Sorry about that.
> 
> I'll take your patch and refactor mine on top of it :-)
> 
> Patch looks good - maybe except for the two consecutive empty lines.
> The commit message - I prefer the commit title to be in present tense (but
> don't always catch it when people write it in past tense).

Oh, and the missing space on both sides of '=' - I'll push the commit
soon, please look at what ended up in master and compare to what you sent

I know these are tiny nit-picks, but consistency is really important to
make the code easy to read and intuitive to understand.

/D


More information about the subsurface mailing list