[PATCH 2/6] macos.c: update the default path retriaval

Lubomir I. Ivanov neolit123 at gmail.com
Tue Oct 6 07:41:47 PDT 2015


On 6 October 2015 at 17:38, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Tue, Oct 06, 2015 at 01:10:17PM +0300, Lubomir I. Ivanov wrote:
>> +const char *system_default_filename(void)
>> +{
>> +     char filename[128] = { 0 };
>> +     if (!*filename) {
>> +             const char *user = getenv("LOGNAME");
>> +             strcat(filename, user);
>
> You are copying a user provided string (environment variable LOGNAME) into
> a fixed length buffer... not a good plan :-)
>
> I'll fix that.
>

linux.c also has the same, BTW.

lubomir
--


More information about the subsurface mailing list