[PATCH] Wrong maxdepth AND watertemp when splitting dives

Giorgio Marzano marzano.giorgio at gmail.com
Tue Oct 6 12:30:56 PDT 2015


This is the updated patch

This time I used qtcreator. Let me know if formatting is OK

2015-10-06 16:23 GMT+02:00 Dirk Hohndel <dirk at hohndel.org>:

> On Tue, Oct 06, 2015 at 03:10:22PM +0200, Giorgio Marzano wrote:
> > Dirk,
> >
> >
> > don't know if your patch already cover this, but it seems that also
> > dive->watertemp and dc->watertemp must be invalidated to ensure they get
> > consistent values in split dives.
>
> Good idea - but your patc is not against latest master, right?
>
> Moving this into a helper function sounds smart.
>
> Would you mind resending an updated patch?
>
>
> > BTW i switched to vim and configured .vimrc according to CodingStyles :)
>
>
> Nice... let me check the patch...
>
> Looks perfect :-)
>
> Thanks for your work on this.
>
> /D
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151006/500ea2ab/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Force-split-dives-attributes-update.patch
Type: text/x-patch
Size: 2796 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151006/500ea2ab/attachment.bin>


More information about the subsurface mailing list