Patch 3 - replacing 1 and 2 - sorry
Dirk Hohndel
dirk at hohndel.org
Sat Oct 10 05:52:25 PDT 2015
> On Oct 10, 2015, at 1:32 AM, Guido Lerch <guido.lerch at gmail.com> wrote:
>
>
>
> 2015-10-09 19:25 GMT+02:00 Tomaz Canabrava <tcanabrava at kde.org <mailto:tcanabrava at kde.org>>:
> looking.
>
> On Fri, Oct 9, 2015 at 2:19 PM, Dirk Hohndel <dirk at hohndel.org <mailto:dirk at hohndel.org>> wrote:
> On Fri, Oct 09, 2015 at 06:09:26PM +0200, Guido Lerch wrote:
> > Finally I think on El Captain and Mavericks the main window size, position
> > and state
> > is preserved.
> >
> > I have no Yosemite at this point in time, Robert, can you test ?
> >
> > Sorry for the first two quick shots ...
>
> So since you are changing generic code that runs on all platforms I'm a
> bit worried.... this is not just "does it work on various flavors of Mac?"
> but "does it work on all OSs, with all desktop environments?".
>
> I killed my Linux environment :-( and have to rebuild, so in the future I will be able to
> do some testing there too.
> I am concerned as well, hence I asked for additional testing.
> I am assuming I broke nothing as I found the changes in the last master this morning.
I tested this here on two different Linux flavors and on Windows and Tomaz did a
code review and ACLed it...
So while I was nervous, it felt like such an improvement that I didn't want to ignore it
/D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151010/5ed10f92/attachment.html>
More information about the subsurface
mailing list