[PATCH] In git load parse hash before adding picture to dive

Robert Helling helling at lmu.de
Wed Oct 14 08:09:26 PDT 2015


sorry I found this so late in the process.

But I realized only now (since otherwise image caching always came in my way so the problem did not show up) that when loading from git, the image hashes are not loaded because the picture was added to the dive before the hash was parsed.

This patch which switches the order of two lines in load-git.c fixes the problem for me but since that part of the code contains some magic I do not fully understand somebody else should have a look at this. Linus?


PS: Sorry again
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151014/deaf0b3f/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Parse-hash-before-adding-picture-to-dive.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151014/deaf0b3f/attachment.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151014/deaf0b3f/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151014/deaf0b3f/attachment.sig>

More information about the subsurface mailing list