Proposal on new planner layout

[Rick Walsh]

Hi Sergey,

On 15 October 2015 at 23:46, Sergey Starosek <sergey.starosek at gmail.com>
wrote:

>
> Hi all,
>
> See attached image. With this approach:
>
>    - new planner options may be easily added to the left panel, which is
>    scrollable
>    - sections on the left may be collapsible
>    - layout seems to be more suitable for lower screen resolutions
>
> What do you think?
>
Thank you for looking at this.  I think a lot could be done to improve the
layout of the planner, and right now, at the start of a release cycle is a
good time to discuss what we should do.

One thing to consider, is what it would look like on other people's
systems.  Being entirely selfish, I've attached a screenshot of what the
planner looks like for me, and my 1366x768 laptop display.

Currently, the planner layout does not suit it very well.  In the attached
screenshot, you can see that if I size the gas and planner point tables to
see all the rows, I can only display half the preferences, and the first
few lines of the plan details.  I'm keen to test it on my system, but I
think your proposal would be an improvement for me if I shrink the profile
plot frame, which is completely fine.

Other improvements I think could be gained, especially for people with
short/small displays, by:

   - Reduce cell padding, in gas and waypoint tables (actually all tables
   in Subsurface)
   - Possibly reduce font size in tables
   - Possibly reduce font size in dive plan details / dive log notes
   - Get rid of 'Rates' heading in planner preferences, replace 'ascent'
   with 'ascent rates', 'descent' with 'descent rate'
   - De-link planner frame sizes from the usual Subsurface display (i.e.
   when showing dive log table, dive details, dive profile, Marble map), so
   there's no need to resize everything every time the planner is opened or
   closed.  I think your proposal implies this because the layout is different.


On 16 October 2015 at 01:40, Martin Měřinský <mermar at centrum.cz> wrote:
>
> Hello.
> I like your proposal. I would propose a few more changes.
>
> Align "Safety stop" checkbox to the left with "Reserve gas".
>

Agreed

> Move "Open circuit" list to the right and add "Circuit" caption to the
> left.

I generally agree but think "Circuit" looks a bit odd as a caption, maybe
"Mode"

>
> Move "Print" button close to "Save" and "Cancel" buttons.
>

I'm not sure - I think "Print" just prints the details/notes

> Rename "Notes" to "Plan format".

Agreed (for background, the "Plan details" window used to be called
"Notes", because that's what gets saved to dive log notes when you save the
plan)

>
> Move "Rates", "Gas options" (and "Notes"?) to Preferences. These are
> user specific, not dive specific. They doesn't change to often.
>

I'm not sure.  I understand your point, but I like see the effect of
changing these are.  Especially SAC (my buddy's might be more/less than
mine, SAC generally increases in rough conditions, etc.).  The other
preferences I also test the effect of changing, but mostly for
development/debugging purposes.  Putting this in the Subsurface preferences
adds several new clicks: file -> preferences -> dive planner.

I hate to suggest a new dialog, but I'm almost tempted to suggest a new
"dive plan preferences" dialog that's accessed by a button in the planner.
Or, this could be in the general subsurface preferences, but the
preferences button in the planner goes straight to that tab.  Adds one new
click to access.


> Move "Available gases" and "Dive planner points" under "Planning".
>
> At the end, you would have two panels. On the left user input. On the
> right generated plan (profile on the top and text plan at the bottom).
>
> I took the liberty to modify your proposal, see attachement.
>

Mock-ups are great.  Thanks


> -----
>
> While talking about UI, I would like to point out to several more
> things.
>
> Would it be possible to remove blank white space in "Available gases"
> and "Dive planner points" tables? Tables should grow vertically with
> increasing number of lines, but showing empty place is wasting.
>

Yes!

> "Plus" button for "Available gases" and "Dive planner points" could be
> directly above or under "Trash" button.
>
> Put space between number and unit. Like in Salinity. Everywhere,
> including generated plan. It is much better to read.
>

This is my personal preference too, but it goes to Subsurface overall
style.  I think consensus was drop the space (see info/stats tab of dive
log).


> Move File -> Preferences to Edit -> Preferences. It makes much more
> sence.

I always think of "edit" as cut, paste, undo, redo.  Not sure preferences
fits here (yes, I know some programs have it here).  I think File is a good
a place as anywhere.


>
> "Information" box in Profile pops up after entering Profile with mouse
> cursor. But doesn't disappear after moving cursor away. Shouldn't it? Is
> there way to hide Information box somehow?

This is a Subsurface profile general thing.  Note, you can drag the box
around so it doesn't obstruct the view.

>
> When planning dive, in Profile, there are moving lines following the
> cursor. Could they exist also in Profile of finished dive?
>
> Would it make sence to plan in already known location? Height above sea
> level and Salinity could be taken from location data. I'm not sure if it
> would be usefull.
>

Clever, but I think might be more effort that is worth.  But maybe people
who do altitude diving would think it's a killer feature.

> -----
>
> With current 4.5.0 release, there are some minor bugs.
>
> In planner, last "Dive planner point" cannot be deleted and has trash
> icon striked out. Last "Available gas" cannot be deleted neither, but
> it's icon is not striked out.
>
> In brand new plan, I get "Too many gas mixes" warning. I don't know, why
> twice. And I don't know why "Too many gas mixes", while I have none. If
> I close the warning, and click "+" to add gas, I get the warning again.

This is a bug I haven't come across before.  Could you start a new thread,
and in particular, mention what the selected dive was when you opened the
planner.  The planner gasses and cylinders default to those of the selected
dive.  Maybe you selected several dives, or a dive trip at the time.

>
> Best regards. Martin M.
>
> PS: Sorry for my English.
You English is fine.

Cheers,

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151016/0a2a4af9/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: myplanner screen.png
Type: image/png
Size: 199932 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151016/0a2a4af9/attachment-0001.png>