Subsurface 4.5 (Win10) crash after adding dive with planner

[Dirk Hohndel]

> On Oct 17, 2015, at 9:58 PM, Miika Turkia <miika.turkia at gmail.com> wrote:
> 
> On Sun, Oct 18, 2015 at 7:51 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>> 
>>> On Oct 17, 2015, at 7:39 PM, Linus Torvalds <torvalds at linux-foundation.org> wrote:
>>> 
>>> On Sat, Oct 17, 2015 at 7:32 PM, Linus Torvalds
>>> <torvalds at linux-foundation.org> wrote:
>>>> 
>>>> But right you are. That explains it. The German translation format
>>>> string is corrupt.
>>> 
>>> True for both Swiss and German locale (de_CH and de_DE).
>> 
>> Yep, thanks Lubomir and Linus, that's clearly it.
>> I just got back from dinner and looked at it on the phone while there and something looked
>> odd about the format string but I just figured "it's the phone screen"...
>> 
>> I'll fix that on Transifex. And I'll check the other languages as well, Benjamin.
> 
> We are slowly getting a nice list of formatting options that must be
> rejected before release. Time for some scripting, I assume.
> Unfortunately all % signs are not marking an argument but might be
> literal % in the output...

It should be a valid requirement to say that the number of '%' in the original
string and the translation must be the same.

That would have been enough to catch this one.

I'm done reviewing. Only wrong in the two German translations. I also realized
that we had a near identical string that was translated in many of the languages
but that this one was missing in some of them, so I did some "pattern matching
translations".

Benjamin: the string is untranslated in Hebrew.

/D