[PATCH 3/3] Add perl function indent_ctor_init_lists to whitespace.pl

Dirk Hohndel dirk at hohndel.org
Mon Oct 19 07:39:18 PDT 2015


On Sat, Oct 17, 2015 at 05:05:36PM -0700, K. "pestophagous" Heller wrote:
> 
> I ran this version of whitespace.pl on most of the source files in the
> subsurface repo and I was very happy with the results.  I did not find
> anywhere that 'indent_ctor_init_lists' led to side-effects on lines
> that have nothing to do with ctors.

Cool

> An additional comment about whitespace.pl:
> 
> So far in my testing with clang-format 3.5.0, there appear to be parts
> of whitespace.pl that can now be removed. (I have not made any
> removals, though.)  For example: clang-format does handle the
> Q_FOREACH and for_each_dive in my testing.  So I don't think
> whitespace.pl needs to manipulate 'each'es.  Also, I am not sure that
> I see any 'messing-up' with clang adding 4 spaces or 6 spaces
> anywhere.

Feel free to continue to improve the tool. I'm glad for all the help I can
get there. I don't use it a lot - mostly when I get frustrated while
editing a file... I definitely am not running it after every commit :-)

Still, I'd love for the tool to be better.

Thanks

/D


More information about the subsurface mailing list