[PATCH] Re: Minor planner bugs

[Robert Helling]

Hi,

> On 19.10.2015, at 08:11, Martin Měřinský <mermar at centrum.cz> wrote:
> 
> Hi.
> I have found a few minor bugs in 4.5.0 planner. I mentioned it in
> "Proposal on new planner layout" thread, but was asked to send it
> separately.
> 
> Start Subsurface (no log file).
> Ctrl+l (Log -> Plan dive).
> I get warning "Too many gas mixes".
> Warning text is there twice.
> It doesn't make sense, because I have nothing in Available gases.
> 
> Close the warning.
> Hit plus button, to add gas.
> I get warning "Too many gas mixes" again.
> 
> When going to plan dive, there is automatically one dive planner point,
> but no gas. I would suppose to have one gas as well.

I could not reproduce that behavior. But looking at the code, there might be the case that there is a current dive but that that dive does not have any cylinder. Here is a patch that is supposed to catch that case and add a default cylinder instead. Could you please test that this patch solves this problem?

There is a second patch that adds a recently added dependency to the INSTALL file (I could not build without it).

> 
> Last Dive planner point cannot be removed. The trash icon is stroked
> out. Last available gas (once added) cannot be removed neither, but its
> icon is not stroked out. In fact, if I add multiple gases, none of them
> can be deleted.


The planner should always have at least one gas and one waypoint. A stroked out icon for the last gas was added by recent patch.



Best
Robert

--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151020/0bf61476/attachment-0003.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Mention-hidapi-in-Mac-building-instructions.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151020/0bf61476/attachment-0002.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151020/0bf61476/attachment-0004.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Always-make-sure-the-planner-starts-with-at-least-one-.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151020/0bf61476/attachment-0003.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151020/0bf61476/attachment-0005.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151020/0bf61476/attachment-0001.sig>